Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Return type of unmount is void #857

Merged
merged 1 commit into from
Jan 7, 2021
Merged

fix: Return type of unmount is void #857

merged 1 commit into from
Jan 7, 2021
+1 −1

Conversation

sanchit121
Copy link
Contributor

#856

Checklist:

  • Documentation added to the
    docs site N/A
  • Tests
  • Typescript definitions updated
  • Ready to be merged

@sanchit121 sanchit121 mentioned this pull request Jan 7, 2021
Closed
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 7, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 35b3e61:

Sandbox Source
React Configuration
react-testing-library-examples Configuration

@codecov
Copy link

codecov bot commented Jan 7, 2021 •
edited
Loading

Codecov Report

Merging #857 (35b3e61) into master (64a8b9c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #857   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          140       140           
  Branches        28        28           
=========================================
  Hits           140       140

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64a8b9c...35b3e61. Read the comment docs.

@eps1lon eps1lon changed the title Update return type of unmount fix: Return type of unmount is void Jan 7, 2021
eps1lon
eps1lon approved these changes Jan 7, 2021
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@eps1lon eps1lon merged commit 1389f09 into testing-library:master Jan 7, 2021
@eps1lon
Copy link
Member

eps1lon commented Jan 7, 2021

@all-contributors add @sanchit121 for bug, code

@allcontributors allcontributors bot mentioned this pull request Jan 7, 2021
Merged
@allcontributors
Copy link
Contributor

@eps1lon

I've put up a pull request to add @sanchit121! 🎉

@eps1lon eps1lon linked an issue Jan 7, 2021 that may be closed by this pull request
Return type of unmount function #856
Closed
@github-actions
Copy link

github-actions bot commented Jan 7, 2021

🎉 This PR is included in version 11.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sanchit121
Copy link
Contributor Author

sanchit121 commented Jan 7, 2021 •
edited
Loading

Thank you so much @eps1lon

This was referenced Mar 10, 2021
Closed
Merged
Closed
Merged
Merged
Merged
Closed
Closed
Closed
Closed
Merged
Merged
Merged
This was referenced Mar 17, 2021
Merged
Closed
Closed
@h-gj h-gj mentioned this pull request Jun 6, 2024
Open
@bharatprakashparakh bharatprakashparakh mentioned this pull request Jun 14, 2024
Open
@h-gj h-gj mentioned this pull request Jul 12, 2024
Open
@sumitmishra04 sumitmishra04 mentioned this pull request Jul 27, 2024
Open
@h-gj h-gj mentioned this pull request Jul 27, 2024
Open
@avinashkumar18 avinashkumar18 mentioned this pull request Jul 31, 2024
Open
@h-gj h-gj mentioned this pull request Aug 23, 2024
Open
@h-gj h-gj mentioned this pull request Aug 30, 2024
Open
@PoojaPanchal12 PoojaPanchal12 mentioned this pull request Aug 31, 2024
Open
@harrisonho99 harrisonho99 mentioned this pull request Sep 10, 2024
Open
@damiancolaneri damiancolaneri mentioned this pull request Sep 10, 2024
Open
@deniavsa deniavsa mentioned this pull request Sep 12, 2024
Open
@harrisonho99 harrisonho99 mentioned this pull request Sep 13, 2024
Open
@damiancolaneri damiancolaneri mentioned this pull request Sep 13, 2024
Open
@harrisonho99 harrisonho99 mentioned this pull request Sep 13, 2024
Open
@deniavsa deniavsa mentioned this pull request Sep 13, 2024
Open
This was referenced Sep 14, 2024
Open
Open
@damiancolaneri damiancolaneri mentioned this pull request Sep 17, 2024
Open
@harrisonho99 harrisonho99 mentioned this pull request Sep 18, 2024
Open
@damiancolaneri damiancolaneri mentioned this pull request Sep 18, 2024
Open
@deniavsa deniavsa mentioned this pull request Sep 18, 2024
Open
@damiancolaneri damiancolaneri mentioned this pull request Sep 20, 2024
Open
@deniavsa deniavsa mentioned this pull request Sep 20, 2024
Open
@harrisonho99 harrisonho99 mentioned this pull request Sep 21, 2024
Open
@damiancolaneri damiancolaneri mentioned this pull request Sep 21, 2024
Open
@deniavsa deniavsa mentioned this pull request Sep 21, 2024
Open
@harrisonho99 harrisonho99 mentioned this pull request Sep 22, 2024
Open
@h-gj h-gj mentioned this pull request Oct 3, 2024
Open
@h-gj h-gj mentioned this pull request Nov 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return type of unmount function
2 participants
@sanchit121 @eps1lon